Handle Plug.Parsers.UnsupportedMediaTypeError #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnsupportedMediaTypeError is raised when Plug.Parsers doesn't support the content-type specified in the request. Similarly to Phoenix.Router.NoRouteError, this shouldn't be treated as an error span, since anyone can send an unsupported media type to the server. Unlike NoRouteError, we can keep the resource name. This change matches the UnsupportedMediaTypeError and skips marking the trace as an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40.
Plug.Parsers.UnsupportedMediaTypeErroris raised whenPlug.Parsersdoesn't support the content-type specified in the request.Similarly to
Phoenix.Router.NoRouteError, this shouldn't be treated as an error span, since anyone can send an unsupported media type to the server. UnlikePhoenix.Router.NoRouteError, we can keep the resource name.This change matches the
Plug.Parsers.UnsupportedMediaTypeErrorinSpandexPhoenix.mark_span_as_error/3and skips marking the trace as an error.Here's a sneak peek from our production monitoring where the change was already applied: