[SIEM][Detection Engine][Lists] Adds "wait_for" to all the create, up…

…date, patch, delete endpoints (elastic#71290)

## Summary

* Adds "wait_for" to all the create, update, patch, and delete endpoints
* Ran some quick tests against import and the performance still looks acceptable
* Updates the unit tests to reflect the addition

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

x-pack/plugins/lists/server/services/items/create_list_item.test.ts

@@ -36,6 +36,7 @@ describe('crete_list_item', () => {
       body,
       id: LIST_ITEM_ID,
       index: LIST_ITEM_INDEX,
+      refresh: 'wait_for',
     };
     expect(options.callCluster).toBeCalledWith('index', expected);
   });

x-pack/plugins/lists/server/services/items/create_list_item.ts

@@ -71,6 +71,7 @@ export const createListItem = async ({
       body,
       id,
       index: listItemIndex,
+      refresh: 'wait_for',
     });
 
     return {

x-pack/plugins/lists/server/services/items/create_list_items_bulk.test.ts

@@ -33,6 +33,7 @@ describe('crete_list_item_bulk', () => {
         secondRecord,
       ],
       index: LIST_ITEM_INDEX,
+      refresh: 'wait_for',
     });
   });
 
@@ -70,6 +71,7 @@ describe('crete_list_item_bulk', () => {
         },
       ],
       index: '.items',
+      refresh: 'wait_for',
     });
   });
 });

x-pack/plugins/lists/server/services/items/create_list_items_bulk.ts

@@ -84,6 +84,7 @@ export const createListItemsBulk = async ({
     await callCluster('bulk', {
       body,
       index: listItemIndex,
+      refresh: 'wait_for',
     });
   } catch (error) {
     // TODO: Log out the error with return values from the bulk insert into another index or saved object

x-pack/plugins/lists/server/services/items/delete_list_item.test.ts

@@ -47,6 +47,7 @@ describe('delete_list_item', () => {
     const deleteQuery = {
       id: LIST_ITEM_ID,
       index: LIST_ITEM_INDEX,
+      refresh: 'wait_for',
     };
     expect(options.callCluster).toBeCalledWith('delete', deleteQuery);
   });

x-pack/plugins/lists/server/services/items/delete_list_item.ts

@@ -28,6 +28,7 @@ export const deleteListItem = async ({
     await callCluster('delete', {
       id,
       index: listItemIndex,
+      refresh: 'wait_for',
     });
   }
   return listItem;

x-pack/plugins/lists/server/services/items/delete_list_item_by_value.test.ts

@@ -52,6 +52,7 @@ describe('delete_list_item_by_value', () => {
         },
       },
       index: '.items',
+      refresh: 'wait_for',
     };
     expect(options.callCluster).toBeCalledWith('deleteByQuery', deleteByQuery);
   });

x-pack/plugins/lists/server/services/items/delete_list_item_by_value.ts

@@ -48,6 +48,7 @@ export const deleteListItemByValue = async ({
       },
     },
     index: listItemIndex,
+    refresh: 'wait_for',
   });
   return listItems;
 };

x-pack/plugins/lists/server/services/items/update_list_item.ts

@@ -62,6 +62,7 @@ export const updateListItem = async ({
         },
         id: listItem.id,
         index: listItemIndex,
+        refresh: 'wait_for',
       });
       return {
         created_at: listItem.created_at,

x-pack/plugins/lists/server/services/lists/create_list.test.ts

@@ -52,6 +52,7 @@ describe('crete_list', () => {
       body,
       id: LIST_ID,
       index: LIST_INDEX,
+      refresh: 'wait_for',
     };
     expect(options.callCluster).toBeCalledWith('index', expected);
   });

x-pack/plugins/lists/server/services/lists/create_list.ts

@@ -67,6 +67,7 @@ export const createList = async ({
     body,
     id,
     index: listIndex,
+    refresh: 'wait_for',
   });
   return {
     id: response._id,

x-pack/plugins/lists/server/services/lists/delete_list.test.ts

@@ -47,6 +47,7 @@ describe('delete_list', () => {
     const deleteByQuery = {
       body: { query: { term: { list_id: LIST_ID } } },
       index: LIST_ITEM_INDEX,
+      refresh: 'wait_for',
     };
     expect(options.callCluster).toBeCalledWith('deleteByQuery', deleteByQuery);
   });
@@ -59,6 +60,7 @@ describe('delete_list', () => {
     const deleteQuery = {
       id: LIST_ID,
       index: LIST_INDEX,
+      refresh: 'wait_for',
     };
     expect(options.callCluster).toHaveBeenNthCalledWith(2, 'delete', deleteQuery);
   });

x-pack/plugins/lists/server/services/lists/delete_list.ts

@@ -36,11 +36,13 @@ export const deleteList = async ({
         },
       },
       index: listItemIndex,
+      refresh: 'wait_for',
     });
 
     await callCluster('delete', {
       id,
       index: listIndex,
+      refresh: 'wait_for',
     });
     return list;
   }

x-pack/plugins/lists/server/services/lists/update_list.ts

@@ -55,6 +55,7 @@ export const updateList = async ({
       body: { doc },
       id,
       index: listIndex,
+      refresh: 'wait_for',
     });
     return {
       created_at: list.created_at,