Make vis_default_editor a proper plugin (elastic#77869)

spalger · Sep 21, 2020 · 53142d8 · 53142d8
1 parent 496152e
commit 53142d8
Show file tree

Hide file tree

Showing 15 changed files with 36 additions and 15 deletions.
diff --git a/docs/developer/plugin-list.asciidoc b/docs/developer/plugin-list.asciidoc
@@ -181,6 +181,12 @@ which also contains the timelion APIs and backend, look at the vis_type_timelion
 To integrate with the telemetry services for usage collection of your feature, there are 2 steps:
 
 
+|{kib-repo}blob/{branch}/src/plugins/vis_default_editor/README.md[visDefaultEditor]
+|The default editor is used in most primary visualizations, e.x. Area, Data table, Pie, etc.
+It acts as a container for a particular visualization and options tabs. Contains the default "Data" tab in public/components/sidebar/data_tab.tsx.
+The plugin exposes the static DefaultEditorController class to consume.
+
+
 |{kib-repo}blob/{branch}/src/plugins/vis_type_markdown/README.md[visTypeMarkdown]
 |The markdown visualization that can be used to place text panels on dashboards.
 

diff --git a/src/plugins/charts/kibana.json b/src/plugins/charts/kibana.json
@@ -3,5 +3,5 @@
   "version": "kibana",
   "server": true,
   "ui": true,
-  "requiredBundles": ["kibanaUtils", "kibanaReact", "data"]
+  "requiredBundles": ["visDefaultEditor"]
 }
diff --git a/src/plugins/input_control_vis/kibana.json b/src/plugins/input_control_vis/kibana.json
@@ -4,6 +4,6 @@
   "kibanaVersion": "kibana",
   "server": true,
   "ui": true,
-  "requiredPlugins": ["data", "expressions", "visualizations"],
+  "requiredPlugins": ["data", "expressions", "visualizations", "visDefaultEditor"],
   "requiredBundles": ["kibanaReact"]
 }
diff --git a/src/plugins/region_map/kibana.json b/src/plugins/region_map/kibana.json
@@ -14,7 +14,7 @@
   ],
   "requiredBundles": [
     "kibanaUtils",
-    "kibanaReact",
-    "charts"
+    "charts", 
+    "visDefaultEditor"
   ]
 }
diff --git a/src/plugins/tile_map/kibana.json b/src/plugins/tile_map/kibana.json
@@ -14,7 +14,7 @@
   ],
   "requiredBundles": [
     "kibanaUtils",
-    "kibanaReact",
-    "charts"
+    "charts",
+    "visDefaultEditor"
   ]
 }
diff --git a/src/plugins/vis_default_editor/kibana.json b/src/plugins/vis_default_editor/kibana.json
@@ -0,0 +1,6 @@
+{
+  "id": "visDefaultEditor",
+  "version": "kibana",
+  "ui": true,
+  "requiredBundles": ["kibanaUtils", "kibanaReact", "data"]
+}
diff --git a/src/plugins/vis_default_editor/public/index.ts b/src/plugins/vis_default_editor/public/index.ts
@@ -24,3 +24,11 @@ export * from './editor_size';
 export * from './vis_options_props';
 export * from './utils';
 export { ISchemas, Schemas, Schema } from './schemas';
+
+/** dummy plugin, we just want visDefaultEditor to have its own bundle */
+export function plugin() {
+  return new (class VisDefaultEditor {
+    setup() {}
+    start() {}
+  })();
+}
diff --git a/src/plugins/vis_type_markdown/kibana.json b/src/plugins/vis_type_markdown/kibana.json
@@ -4,5 +4,5 @@
     "ui": true,
     "server": true,
     "requiredPlugins": ["expressions", "visualizations"],
-    "requiredBundles": ["kibanaUtils", "kibanaReact", "data", "charts", "visualizations", "expressions"]
+    "requiredBundles": ["kibanaUtils", "kibanaReact", "charts", "visualizations", "expressions", "visDefaultEditor"]
 }
diff --git a/src/plugins/vis_type_metric/kibana.json b/src/plugins/vis_type_metric/kibana.json
@@ -5,5 +5,5 @@
   "server": true,
   "ui": true,
   "requiredPlugins": ["data", "visualizations", "charts", "expressions"],
-  "requiredBundles": ["kibanaUtils", "kibanaReact"]
+  "requiredBundles": ["kibanaUtils", "visDefaultEditor"]
 }
diff --git a/src/plugins/vis_type_table/kibana.json b/src/plugins/vis_type_table/kibana.json
@@ -11,8 +11,8 @@
   ],
   "requiredBundles": [
     "kibanaUtils",
-    "kibanaReact",
     "share",
-    "charts"
+    "charts",
+    "visDefaultEditor"
   ]
 }
diff --git a/src/plugins/vis_type_tagcloud/kibana.json b/src/plugins/vis_type_tagcloud/kibana.json
@@ -4,5 +4,5 @@
   "ui": true,
   "server": true,
   "requiredPlugins": ["data", "expressions", "visualizations", "charts"],
-  "requiredBundles": ["kibanaUtils", "kibanaReact"]
+  "requiredBundles": ["kibanaUtils", "kibanaReact", "visDefaultEditor"]
 }
diff --git a/src/plugins/vis_type_timelion/kibana.json b/src/plugins/vis_type_timelion/kibana.json
@@ -5,5 +5,5 @@
   "server": true,
   "ui": true,
   "requiredPlugins": ["visualizations", "data", "expressions"],
-  "requiredBundles": ["kibanaUtils", "kibanaReact"]
+  "requiredBundles": ["kibanaUtils", "kibanaReact", "visDefaultEditor"]
 }
diff --git a/src/plugins/vis_type_vega/kibana.json b/src/plugins/vis_type_vega/kibana.json
@@ -4,5 +4,5 @@
   "server": true,
   "ui": true,
   "requiredPlugins": ["data", "visualizations", "mapsLegacy", "expressions", "inspector"],
-  "requiredBundles": ["kibanaUtils", "kibanaReact"]
+  "requiredBundles": ["kibanaUtils", "kibanaReact", "visDefaultEditor"]
 }
diff --git a/src/plugins/vis_type_vislib/kibana.json b/src/plugins/vis_type_vislib/kibana.json
@@ -5,5 +5,5 @@
   "ui": true,
   "requiredPlugins": ["charts", "data", "expressions", "visualizations", "kibanaLegacy"],
   "optionalPlugins": ["visTypeXy"],
-  "requiredBundles": ["kibanaUtils", "kibanaReact"]
+  "requiredBundles": ["kibanaUtils", "visDefaultEditor"]
 }
diff --git a/src/plugins/visualize/kibana.json b/src/plugins/visualize/kibana.json
@@ -18,6 +18,7 @@
     "kibanaUtils",
     "kibanaReact",
     "home",
-    "discover"
+    "discover",
+    "visDefaultEditor"
   ]
 }