Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-espresso: apply patch to v4.0.0 only #9196

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Conversation

junghans
Copy link
Contributor

# https://github.com/espressomd/espresso/pull/2244
patch('2244.patch')
# espressomd/espresso#2244 merge upstream
patch('2244.patch', when="@4.0.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typically we do ranges here, in case someone adds a minor version bump later, but your decision

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be part of v4.0.1 or @4.0.0 should be fine.

@KaiSzuttor please correct me if I am wrong.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be in 4.0.1

@junghans junghans merged commit 98d8c4d into develop Sep 13, 2018
@junghans junghans deleted the bugfix/py-espresso branch September 13, 2018 10:00
ptbremer pushed a commit to ptbremer/spack that referenced this pull request Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants