-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging_guide.rst: explain forward and backward compat before the less common cases #47402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-app
bot
added
core
PR affects Spack core functionality
dependencies
documentation
Improvements or additions to documentation
labels
Nov 4, 2024
haampie
force-pushed
the
hs/docs/forward-backward-bounds
branch
2 times, most recently
from
November 4, 2024 11:49
583a7be
to
924255f
Compare
haampie
force-pushed
the
hs/docs/forward-backward-bounds
branch
from
November 4, 2024 11:52
924255f
to
6ff6859
Compare
alalazo
reviewed
Nov 4, 2024
alalazo
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart one minor comment.
Supersedes the old PR #35002. |
alalazo
approved these changes
Nov 4, 2024
This was referenced Nov 4, 2024
Merged
haampie
added a commit
that referenced
this pull request
Nov 5, 2024
…ess common cases (#47402) The idea is to go from most to least used: backward compat -> forward compat -> pinning on major or major.minor version -> pinning specific, concrete versions. Further, the following ```python # backward compatibility with Python depends_on("[email protected]:") depends_on("[email protected]:", when="@1.2:") depends_on("[email protected]:", when="@1.4:") # forward compatibility with Python depends_on("python@:3.12", when="@:1.10") depends_on("python@:3.13", when="@:1.12") depends_on("python@:3.14") ``` is better than disjoint when ranges causing repetition of the rules on dependencies, and requiring frequent editing of existing lines after new releases are done: ```python depends_on("[email protected]:3.12", when="@:1.1") depends_on("[email protected]:3.12", when="@1.2:1.3") depends_on("[email protected]:3.12", when="@1.4:1.10") depends_on("[email protected]:3.13", when="@1.11:1.12") depends_on("[email protected]:3.14", when="@1.13:")
haampie
added a commit
that referenced
this pull request
Nov 18, 2024
…ess common cases (#47402) The idea is to go from most to least used: backward compat -> forward compat -> pinning on major or major.minor version -> pinning specific, concrete versions. Further, the following ```python # backward compatibility with Python depends_on("[email protected]:") depends_on("[email protected]:", when="@1.2:") depends_on("[email protected]:", when="@1.4:") # forward compatibility with Python depends_on("python@:3.12", when="@:1.10") depends_on("python@:3.13", when="@:1.12") depends_on("python@:3.14") ``` is better than disjoint when ranges causing repetition of the rules on dependencies, and requiring frequent editing of existing lines after new releases are done: ```python depends_on("[email protected]:3.12", when="@:1.1") depends_on("[email protected]:3.12", when="@1.2:1.3") depends_on("[email protected]:3.12", when="@1.4:1.10") depends_on("[email protected]:3.13", when="@1.11:1.12") depends_on("[email protected]:3.14", when="@1.13:")
haampie
added a commit
that referenced
this pull request
Nov 18, 2024
…ess common cases (#47402) The idea is to go from most to least used: backward compat -> forward compat -> pinning on major or major.minor version -> pinning specific, concrete versions. Further, the following ```python # backward compatibility with Python depends_on("[email protected]:") depends_on("[email protected]:", when="@1.2:") depends_on("[email protected]:", when="@1.4:") # forward compatibility with Python depends_on("python@:3.12", when="@:1.10") depends_on("python@:3.13", when="@:1.12") depends_on("python@:3.14") ``` is better than disjoint when ranges causing repetition of the rules on dependencies, and requiring frequent editing of existing lines after new releases are done: ```python depends_on("[email protected]:3.12", when="@:1.1") depends_on("[email protected]:3.12", when="@1.2:1.3") depends_on("[email protected]:3.12", when="@1.4:1.10") depends_on("[email protected]:3.13", when="@1.11:1.12") depends_on("[email protected]:3.14", when="@1.13:")
This was referenced Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core
PR affects Spack core functionality
dependencies
documentation
Improvements or additions to documentation
v0.22.3
PRs to backport for v0.22.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to go from most to least used: backward compat -> forward compat -> pinning on major or major.minor version -> pinning specific, concrete versions.
Further, imo the following
is better than disjoint when ranges causing repetition of the rules on dependencies, and requiring frequent editing of existing lines after new releases are done: