Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc bug fixes for job processor prometheus logic #740

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Misc bug fixes for job processor prometheus logic #740

merged 5 commits into from
Jan 23, 2024

Conversation

jjnesbitt
Copy link
Collaborator

We were seeing a few issues in sentry from the new job processor work (#723). This PR fixes the following issues:

  1. A typo that was causing non-aws jobs to fail to be tracked correctly
  2. A bug in handling node model creation
  3. Issues resulting from static step sizes in range queries. This is because if a job is sufficiently short (a minute or less), the previous step size of 30 seconds could result in just one or even zero samples, depending on the start and end times used. Now, dynamic step sizes (based on the job duration) are used.

@jjnesbitt jjnesbitt merged commit 9b6bf4a into main Jan 23, 2024
15 checks passed
@jjnesbitt jjnesbitt deleted the prometheus-job-processor-fixes branch January 23, 2024 18:41
@jjnesbitt jjnesbitt mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlamanna danlamanna danlamanna approved these changes

@mvandenburgh mvandenburgh Awaiting requested review from mvandenburgh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjnesbitt @danlamanna