Fixes for prediction API #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR resolves a couple bugs encountered during testing: - package and compiler versions can now be made up of any non-space character. previously, the regex matched semvar formatting, but spackages can have versions in other formats - clarified that specs should be URL-encoded in calls to /api/v1/allocate - fixed issue where expensive variants algo was unable to complete due to some packages storing popular variants string values rather than boolean. ex: quantum-espresso hdf5=none
also fixes a bug which rounded predictions < 0.5 to 0
Previously, requests to the `/v1/allocate` endpoint took around 57ms. After adding a composite index that covers the complete spec and the most common query during the prediction algo, we get a large speedup to around 1.3ms per request. While more indices could be added, the returns were diminished and more risky as we don't want to negatively impact the INSERT speed for the jobs table.
cmelone
force-pushed
the
fix/prediction-fix
branch
from
92da30a to
2c7948a
Compare
`1500m` (millicores) rather than `1.5` (cores) and round up all prediction values to nearest integer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a couple bugs encountered during testing:
/api/v1/allocatequantum-espresso hdf5=none