Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamp parsing #47

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Fix timestamp parsing #47

merged 2 commits into from
Jun 10, 2024

Conversation

cmelone
Copy link
Collaborator

@cmelone cmelone commented May 30, 2024

Gitlab's webhook API falsely represents that it returns timestamps in ISO8601 format, which broke our parser.

We now parse timestamps in the format Gitlab sends in webhooks (2024-05-30 07:01:39 UTC), which is inconsistent with its docs and the job API.

@cmelone cmelone added the bug Something isn't working label May 30, 2024
@cmelone cmelone self-assigned this May 30, 2024
@spack spack deleted a comment from girishbarca Jun 7, 2024
Copy link
Member

@alecbcs alecbcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @cmelone

@alecbcs alecbcs merged commit 0dcac43 into develop Jun 10, 2024
5 checks passed
@alecbcs alecbcs deleted the fix/timestamp-parse branch June 10, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants