Simplify Dockerfile #1642
Merged
Simplify Dockerfile #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttung
force-pushed
the
tonytung-docker
branch
2 times, most recently
from
da862a5
to
d0e6d46
Compare
Codecov Report
@@ Coverage Diff @@
## master #1642 +/- ##
=======================================
Coverage 90.09% 90.09%
=======================================
Files 234 234
Lines 8764 8764
=======================================
Hits 7896 7896
Misses 868 868Continue to review full report at Codecov.
|
shanaxel42
approved these changes
Nov 12, 2019
It simply overlays a python image 3.6 image with a starfish install. No weird conda bugs. It will be fantastic. Changed the entry point so that it's just a bash shell. Depends on #1641 Test plan: `make docker`
ttung
force-pushed
the
tonytung-docker
branch
from
d0e6d46
to
f4e4236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It simply overlays a python image 3.6 image with a starfish install. No weird conda bugs. It will be fantastic.
Changed the entry point so that it's just a bash shell.
Depends on #1641
Test plan:
make docker