Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.) refactoring allen smFish with new spot finding #1580

Closed
wants to merge 0 commits into from

Conversation

shanaxel42
Copy link
Collaborator

No description provided.

@shanaxel42 shanaxel42 force-pushed the saxelrod-allen-refactor branch from 84ba25c to c276476 Compare September 26, 2019 23:09
@shanaxel42 shanaxel42 mentioned this pull request Sep 26, 2019
10 tasks
@codecov-io
Copy link

codecov-io commented Sep 26, 2019

Codecov Report

Merging #1580 into saxelrod-starMap-refactor will decrease coverage by 0.75%.
The diff coverage is 32%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##           saxelrod-starMap-refactor    #1580      +/-   ##
=============================================================
- Coverage                      88.22%   87.47%   -0.76%     
=============================================================
  Files                            149      150       +1     
  Lines                           5240     5308      +68     
=============================================================
+ Hits                            4623     4643      +20     
- Misses                           617      665      +48
Impacted Files Coverage Δ
...spots/DetectSpots/trackpy_local_max_peak_finder.py 90.69% <0%> (-2.16%) ⬇️
starfish/core/spots/FindSpots/__init__.py 100% <100%> (ø) ⬆️
starfish/core/types/_constants.py 98.24% <100%> (+0.03%) ⬆️
starfish/core/spots/DecodeSpots/trace_builders.py 64.51% <26.66%> (-35.49%) ⬇️
...e/spots/FindSpots/trackpy_local_max_peak_finder.py 30.61% <30.61%> (ø)
...rfish/test/full_pipelines/api/test_allen_smFISH.py 33.33% <37.5%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2148b4...cc3208b. Read the comment docs.

@shanaxel42 shanaxel42 force-pushed the saxelrod-allen-refactor branch 5 times, most recently from f9c201c to cc3208b Compare September 27, 2019 17:54
@shanaxel42 shanaxel42 changed the title refactoring allen smFish with new spot finding 4.) refactoring allen smFish with new spot finding Oct 1, 2019
@shanaxel42 shanaxel42 force-pushed the saxelrod-starMap-refactor branch from f2148b4 to e0d8464 Compare October 1, 2019 14:15
@shanaxel42 shanaxel42 closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants