Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace most instances of starfish.image.Filter.Reduce with imagestack.reduce #1548

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Sep 13, 2019

Unless the reduction is happening multiple times, it's simpler to represent a stack reduction as imagestack.reduce

Test plan: travis thanks!
Depends on #1539

@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #1548 into master will increase coverage by 1.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1548      +/-   ##
=========================================
+ Coverage   88.25%     90%   +1.74%     
=========================================
  Files         152     223      +71     
  Lines        5245    8261    +3016     
=========================================
+ Hits         4629    7435    +2806     
- Misses        616     826     +210
Impacted Files Coverage Δ
...core/spots/DetectSpots/test/test_synthetic_data.py 100% <0%> (ø)
starfish/core/experiment/test/test_experiment.py 100% <0%> (ø)
...y_table/test/test_intensity_table_serialization.py 100% <0%> (ø)
...tarfish/core/segmentation_mask/test/test_expand.py 100% <0%> (ø)
starfish/core/imagestack/test/test_export.py 100% <0%> (ø)
...intensity_table/test/test_synthetic_intensities.py 100% <0%> (ø)
...rfish/core/intensity_table/test/test_to_mermaid.py 100% <0%> (ø)
starfish/core/test/factories.py 88.97% <0%> (ø)
...sh/core/expression_matrix/test/test_concatenate.py 100% <0%> (ø)
starfish/core/test/test_synthetic_spot_creation.py 100% <0%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf1d96...f612f8a. Read the comment docs.

@ttung ttung force-pushed the tonytung-use-map-reduce branch 2 times, most recently from fa479cb to 87b6956 Compare September 18, 2019 17:56
@ttung ttung force-pushed the tonytung-use-map-reduce branch 2 times, most recently from 755a67d to 8216d33 Compare September 18, 2019 21:24
@ttung ttung force-pushed the tonytung-use-map-reduce branch 3 times, most recently from 873a327 to a108ce5 Compare September 18, 2019 22:53
@ttung ttung force-pushed the tonytung-use-map-reduce branch 2 times, most recently from 40d8e4e to 7fd6a53 Compare September 20, 2019 01:48
@ttung ttung force-pushed the tonytung-use-map-reduce branch 2 times, most recently from 3380d78 to 88261ac Compare October 1, 2019 05:06
@ttung ttung force-pushed the tonytung-use-map-reduce branch 2 times, most recently from 1a6f306 to 28d15b0 Compare October 4, 2019 17:53
@ttung ttung force-pushed the tonytung-use-map-reduce branch 3 times, most recently from ff2af22 to a180d72 Compare October 9, 2019 21:21
@ttung ttung force-pushed the tonytung-use-map-reduce branch 2 times, most recently from 599453e to aa5a5d0 Compare October 10, 2019 00:03
@ttung ttung changed the base branch from tonytung-map-reduce to master October 10, 2019 06:16
@ttung ttung force-pushed the tonytung-use-map-reduce branch 5 times, most recently from c8858c4 to 7cd93ae Compare October 10, 2019 17:45
…k.reduce

Unless the reduction is happening multiple times, it's simpler to represent a stack reduction as imagestack.reduce

Test plan: travis thanks!
@ttung ttung merged commit 3cd0df6 into master Oct 10, 2019
@ttung ttung deleted the tonytung-use-map-reduce branch October 10, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants