Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AL-852: GWCS should respect the bounding box on inverse transforms #263

Closed
wants to merge 3 commits into from

Conversation

nden
Copy link
Collaborator

@nden nden commented Jun 12, 2024

Resolves JP-nnnn
Resolves RCAL-nnnn

Closes #

The GWCS PR is spacetelescope/gwcs#498
The changes here use the WCS API in order to pick up the bounding box.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@nden nden requested a review from a team as a code owner June 12, 2024 14:26
@nden nden marked this pull request as draft June 12, 2024 14:26
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.87%. Comparing base (af5aefb) to head (315da2d).
Report is 214 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/alignment/util.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
- Coverage   85.18%   83.87%   -1.31%     
==========================================
  Files          35       35              
  Lines        6797     6984     +187     
==========================================
+ Hits         5790     5858      +68     
- Misses       1007     1126     +119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kmacdonald-stsci kmacdonald-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some version tests and downstream tests failing. Is that expected?

@@ -269,7 +269,7 @@ def _calculate_new_wcs(ref_model, shape, wcs_list, fiducial, crpix=None, transfo
----------
ref_model :
The reference model to be used when extracting metadata.

bp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

@hbushouse
Copy link
Collaborator

@nden Is this something that you want to try to get into the jwst B11.0 release next week?

@nden nden closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants