-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AL-852: GWCS should respect the bounding box on inverse transforms #263
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
- Coverage 85.18% 83.87% -1.31%
==========================================
Files 35 35
Lines 6797 6984 +187
==========================================
+ Hits 5790 5858 +68
- Misses 1007 1126 +119 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some version tests and downstream tests failing. Is that expected?
src/stcal/alignment/util.py
Outdated
@@ -269,7 +269,7 @@ def _calculate_new_wcs(ref_model, shape, wcs_list, fiducial, crpix=None, transfo | |||
---------- | |||
ref_model : | |||
The reference model to be used when extracting metadata. | |||
|
|||
bp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this?
@nden Is this something that you want to try to get into the jwst B11.0 release next week? |
Resolves JP-nnnn
Resolves RCAL-nnnn
Closes #
The GWCS PR is spacetelescope/gwcs#498
The changes here use the WCS API in order to pick up the bounding box.
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)