Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply ruff format and pre-commit checks #8648

Closed

Conversation

zacharyburnett
Copy link
Collaborator

apply pre-commit across repository

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 75.73427% with 347 lines in your changes missing coverage. Please review.

Project coverage is 59.52%. Comparing base (4b77a5e) to head (02bdaca).

Files with missing lines Patch % Lines
jwst/cube_build/cube_build_step.py 52.67% 53 Missing ⚠️
jwst/cube_build/blot_cube_build.py 3.22% 30 Missing ⚠️
jwst/assign_wcs/niriss.py 52.83% 25 Missing ⚠️
jwst/cube_build/cube_build_io_util.py 78.78% 21 Missing ⚠️
jwst/ami/ami_average.py 0.00% 17 Missing ⚠️
jwst/cube_build/cube_build.py 78.48% 17 Missing ⚠️
jwst/combine_1d/combine1d.py 72.54% 14 Missing ⚠️
jwst/background/background_sub.py 48.00% 13 Missing ⚠️
jwst/assign_wcs/nirspec.py 94.31% 12 Missing ⚠️
jwst/assign_wcs/util.py 82.81% 11 Missing ⚠️
... and 36 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8648      +/-   ##
==========================================
- Coverage   59.60%   59.52%   -0.09%     
==========================================
  Files         391      391              
  Lines       39286    39373      +87     
==========================================
+ Hits        23418    23436      +18     
- Misses      15868    15937      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett
Copy link
Collaborator Author

these are way too many changes with diminishing returns for development; closing

@zacharyburnett zacharyburnett deleted the format/ruff branch July 15, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment