-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply ruff format
and pre-commit
checks
#8648
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
source catalog
ami
assign_wcs
associations
background
combine_1d
cube_build
dark_current
dq_init
extract_1d
extract_2d
fits_generator
flatfield
fringe
imprint
ipc
jump
lastframe
linearity
outlier_detection
persistence
photom
pipeline
ramp_fitting
refpix
resample
reset
labels
Jul 15, 2024
github-actions
bot
added
documentation
Wide Field Slitless Spec (WFSS)
path loss
tso_photometry
engdb_tools
tso3 pipeline
white_light
msa_flagging
group_scale
gain_scale
wavecorr
guider_cds
bar shadow
firstframe
installation
detector1
cube_skymatch
mrs_imatch
assign_mtwcs
regression_testing
wfss_contam
residual_fringe
automation
Continuous Integration (CI) and testing automation tools
master_background
source type
labels
Jul 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8648 +/- ##
==========================================
- Coverage 59.60% 59.52% -0.09%
==========================================
Files 391 391
Lines 39286 39373 +87
==========================================
+ Hits 23418 23436 +18
- Misses 15868 15937 +69 ☔ View full report in Codecov by Sentry. |
these are way too many changes with diminishing returns for development; closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ami
ami3 pipeline
assign_mtwcs
assign_wcs
associations
automation
Continuous Integration (CI) and testing automation tools
background
bar shadow
combine_1d
coron3 pipeline
cube_build
cube_skymatch
dark_current
datamodels
detector1
documentation
dq_init
engdb_tools
exp_to_source
extract_1d
extract_2d
FGS
firstframe
fits_generator
flatfield
fringe
gain_scale
group_scale
guider_cds
image2 pipeline
image3 pipeline
imprint
installation
ipc
jump
lastframe
linearity
master_background
MIRI
mrs_imatch
msa_flagging
NIRCAM
NIRISS
NIRSPEC
no-changelog-entry-needed
outlier_detection
path loss
persistence
photom
pipeline
ramp_fitting
refpix
regression_testing
resample
reset
residual_fringe
rscd
saturation
skymatch
source catalog
source type
spec2 pipeline
spec3 pipeline
stpipe
straylight
superbias
testing
tso_photometry
tso3 pipeline
tweakreg
wavecorr
wfs_combine
wfss_contam
white_light
Wide Field Slitless Spec (WFSS)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply
pre-commit
across repositoryChecklist for PR authors (skip items if you don't have permissions or they are not applicable)
added entry inCHANGES.rst
within the relevant release sectionupdated or added relevant testsupdated relevant documentationran regression tests, post a link to the Jenkins job below.How to run regression tests on a PR
Make sure the JIRA ticket is resolved properly