Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip quotation marks as workaround for pytest option parsing #8146

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Dec 18, 2023

This PR addresses an issue where the regression tests fail to parse results, due to what appears to be an issue where the option parser adds quotation marks to the value:
https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST/detail/JWST/2701/pipeline/281/#step-290-log-1

com.fasterxml.jackson.core.JsonParseException: Unexpected character ('j' (code 106)): was expecting comma to separate Object entries
 at [Source: (String)"
{
  "files": [
    {
      "pattern": "/var/jenkins_home/workspace/RT/JWST/conda_python_*",
      "target": ""jwst-pipeline-results""  # <<< Why is this quad-quoted and missing a comma?
    }
  ]
}
"; line: 6, column: 20]

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@hbushouse
Copy link
Collaborator

I find it interesting that another recent run in JWST-Developers-Pull-Requests didn't seem to have this problem. At least the status indicator came back green. https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1107
So what's different about the setup over there?

@hbushouse
Copy link
Collaborator

regtest running at https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/1106/pipeline

This run had lots of unrelated failures and errors, because it was run against CRDS_OPS, which is missing at least one new reference file needed by the latest cal code. It needs CRDS_TEST. Should run using "CRDS_PATH=/grp/crds/jwst/test" in the ENV_VARS.

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Dec 19, 2023

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Dec 19, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants