Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mosviz notebooks to import from jdaviz root package #973

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Nov 24, 2021

Description

This pull request makes all example notebooks consistent in importing the viz tools directly from jdaviz (as opposed to jdaviz.configs.mosviz.helper, etc)

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

* as opposed to jdaviz.configs.mosviz.helper
@kecnry kecnry added trivial Only needs one approval instead of two skip-changelog-checks changelog bot directive labels Nov 24, 2021
@kecnry kecnry added this to the 2.1 milestone Nov 24, 2021
@github-actions github-actions bot added the documentation Explanation of code and concepts label Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #973 (be5ae48) into main (cd826c5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #973   +/-   ##
=======================================
  Coverage   70.06%   70.06%           
=======================================
  Files          71       71           
  Lines        5121     5121           
=======================================
  Hits         3588     3588           
  Misses       1533     1533           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd826c5...be5ae48. Read the comment docs.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is better. Thanks!

@pllim pllim merged commit e338e9b into spacetelescope:main Nov 29, 2021
@kecnry kecnry deleted the notebooks-viz-from-root branch November 29, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Explanation of code and concepts skip-changelog-checks changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants