Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show the scrollbar in the app template #671

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

mariobuikhuizen
Copy link
Collaborator

See #666

Before:
Screenshot 2021-06-08 at 21 52 32

After:
Screenshot 2021-06-08 at 21 52 43

I never saw this issue because I have scroll bars turned off. To see the difference in MacOS "Show scroll bars" has to be set to "Always":
Screenshot 2021-06-08 at 21 55 37

@github-actions github-actions bot added the embed Regarding issues with front-end embedding label Jun 8, 2021
@pllim pllim added Ready for final review bug Something isn't working labels Jun 8, 2021
Copy link
Contributor

@ibusko ibusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@pllim pllim merged commit 9f0ff3e into spacetelescope:main Jun 29, 2021
@pllim pllim mentioned this pull request Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working embed Regarding issues with front-end embedding Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants