Imviz: Fix padding above import button #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
requested review from
duytnguyendtn,
ibusko,
javerbukh and
rosteen
as code owners
astrofrog
changed the title
pllim
approved these changes
May 13, 2021
|
@pllim - can you try the latest version to see if the notebook version is fixed too? |
|
Yes, both fixed now. Thanks! |
|
I've also fixed the vertical alignment of the subset select menu thanks to a suggestion from @mariobuikhuizen. This requires glue-viz/glue-jupyter#226 but we don't have to wait for that to be merged since it's just an aesthetic change and will work fine as is - the change is just so that once glue-viz/glue-jupyter#226 is merged and released the alignment will be fixed. Before
After
|
|
This is good to merge, the readthedocs issue has been fixed by a previous PR. This PR either needs a rebase from @astrofrog or an admin merge from @duytnguyendtn , whichever comes first. |
|
Since it's been fixed, I'll go ahead and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Thanks to @mariobuikhuizen for the fix!
EDIT: Fix #606