Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add CodeQL security check #554

Merged
merged 1 commit into from
May 6, 2021
Merged

TST: Add CodeQL security check #554

merged 1 commit into from
May 6, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 21, 2021

@larrybradley and Lee Quick asked me to do this.

Solution Run time (s) Problems found
bandit 20 0
CodeQL (JavaScript) 60 0
CodeQL (Python) 1800 0

CodeQL results: https://github.com/spacetelescope/jdaviz/security/code-scanning?query=ref%3Arefs%2Fpull%2F554%2Fmerge+tool%3ACodeQL

@pllim

This comment has been minimized.

@pllim pllim requested a review from larrybradley April 21, 2021 22:10
Copy link
Contributor

@ibusko ibusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no expert on this, but since it can be run with no issues, I approve.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weekly seems reasonable

@pllim

This comment has been minimized.

@pllim pllim merged commit ef1b279 into spacetelescope:main May 6, 2021
@pllim pllim deleted the codeql branch May 6, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants