Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footprints: filter by observatory #3345

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Dec 10, 2024

Description

This pull request extends on #3322 by allowing to filter by mission (JWST or Roman) via buttons in the UI or the preset_obs select component in the API.

Screen.Recording.2024-12-10.at.11.12.44.AM.mov

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

kecnry and others added 9 commits December 10, 2024 10:08
* manual options can be either strings or dictionaries
* filters passed to SelectPluginComponent will act on manual items, classes that subclass SelectPluginComponent may choose to ALWAYS include all manual items, ignoring filters
Co-authored-by: Jennifer Kotler <[email protected]>
@kecnry kecnry added this to the 4.1 milestone Dec 10, 2024
@github-actions github-actions bot added imviz plugin Label for plugins common to multiple configurations labels Dec 10, 2024
Comment on lines +915 to +918
@observe('filters')
def _update_items(self, msg={}):
all_items = [self._to_item(opt) for opt in self.manual_options]
self.items = [item for item in all_items if self._is_valid_item(item)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding this to the base class then requires renaming all the inheriting classes to have their methods renamed so that they properly override this instead of resulting in duplicated functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imviz plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant