TST: Skip chronically failing test #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3283 +/- ##
==========================================
- Coverage 88.76% 88.75% -0.01%
==========================================
Files 125 125
Lines 18956 18959 +3
==========================================
+ Hits 16826 16828 +2
- Misses 2130 2131 +1 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
pllim
requested review from
rosteen,
javerbukh,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
rosteen
approved these changes
Nov 12, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Nov 12, 2024
pllim
commented
Nov 12, 2024
| @@ -210,6 +210,7 @@ def test_uri_to_download_specviz(specviz_helper, tmp_path): | |||
| specviz_helper.load_data(uri, cache=True, local_path=local_path) | |||
|
|
|||
|
|
|||
| @pytest.mark.skip(reason="FIXME: Find a file that is not missing from MAST") | |||
There was a problem hiding this comment.
Follow up in https://jira.stsci.edu/browse/JDAT-4921
pllim
added a commit
that referenced
this pull request
Nov 12, 2024
…3-on-v4.0.x Backport PR #3283 on branch v4.0.x (TST: Skip chronically failing test)
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to unblock CI for unrelated PRs until someone picks up ticket to fix the test properly.
Close #3275