-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable file imports when running on external server #3239
Conversation
ca7d365
to
d09fabd
Compare
NOTE: I'm not sure if the auto backport will still work for 3.10.x, if it does not, we can manually backport there (probably will be a changelog conflict anyways due to the 4.0.x changelog entry not existing). |
@@ -76,6 +76,8 @@ Cubeviz | |||
Imviz | |||
^^^^^ | |||
|
|||
- Remove "From File.." option when running on an external server. [#3239] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually do we want to advertise this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it'll be in the PR history regardless 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you insist on change log, I think also need entry under 4.0.x section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is (this one you're commenting on is 4.0.1, the other one is 3.10.4)
p.s. Are these the only ones we need to block? Any others? |
these are all. @gibsongreen can follow the same pattern when implementing subset importing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okie dokie then. Feel free to merge. Thanks for the quick fix!
cc @havok2063
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3239 +/- ##
=======================================
Coverage 88.62% 88.63%
=======================================
Files 125 125
Lines 18775 18779 +4
=======================================
+ Hits 16640 16644 +4
Misses 2135 2135 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to the plugins look good to me and I have this PR bookmarked for the future effort!
This comment was marked as resolved.
This comment was marked as resolved.
… external server
…3239) * disable file imports when running on external server
…er (#3240) Co-authored-by: Kyle Conroy <[email protected]>
…3239) (spacetelescope#3241) * disable file imports when running on external server
…3239) (spacetelescope#3241) * disable file imports when running on external server
Description
This pull request disables "From File..." options for importing catalogs and footprints from a file in cases where jdaviz is running on an external server.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.