Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit conversion UI tweaks #3178

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented Sep 3, 2024

This changes three things that were requested to be updated:

  • update the plugin description to be either config-specific or config-generic
  • consider renaming flux_or_sb to spectrum_y_type (or similar) and updating UI language
  • determine which cases angle unit should be shown (UI and user API). Probably can be disabled in anything without an image viewer.

If "Convert the units of displayed physical quantities." doesn't sound good as more generic language to people I can come up with something else.

@rosteen rosteen added this to the 4.0 milestone Sep 3, 2024
@github-actions github-actions bot added cubeviz specviz imviz plugin Label for plugins common to multiple configurations labels Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.42%. Comparing base (3a0aa4c) to head (aba54a9).
Report is 113 commits behind head on main.

Files with missing lines Patch % Lines
...configs/cubeviz/plugins/moment_maps/moment_maps.py 77.77% 2 Missing ⚠️
...imviz/plugins/aper_phot_simple/aper_phot_simple.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3178   +/-   ##
=======================================
  Coverage   88.42%   88.42%           
=======================================
  Files         122      122           
  Lines       18286    18286           
=======================================
  Hits        16169    16169           
  Misses       2117     2117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@haticekaratay haticekaratay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good to me!

@rosteen rosteen merged commit 785da21 into spacetelescope:main Sep 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz imviz plugin Label for plugins common to multiple configurations specviz UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants