-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solara standalone: default to host='localhost' and allow mult instances #3176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks reasonable, so LGTM as long as this works for @camipacifici . Thanks!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3176 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.01%
==========================================
Files 124 124
Lines 18347 18349 +2
==========================================
Hits 16221 16221
- Misses 2126 2128 +2 ☔ View full report in Codecov by Sentry. |
e5875e5
to
170f4d7
Compare
The port=0 default requires a release and bump in pin to solara.... marking as draft until then. |
b44265a
to
9646571
Compare
Description
This pull request defaults to using
host='localhost'
when launching solara, but allowing the user to override from the CLI, and also uses an open port by default, allowing for multiple instances.The port=0 default requires a release and bump in pin to solara.... marking as draft until then.Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.