Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solara standalone: default to host='localhost' and allow mult instances #3176

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Aug 29, 2024

Description

This pull request defaults to using host='localhost' when launching solara, but allowing the user to override from the CLI, and also uses an open port by default, allowing for multiple instances.

The port=0 default requires a release and bump in pin to solara.... marking as draft until then.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Aug 29, 2024
@kecnry kecnry added this to the 4.0 milestone Aug 29, 2024
@kecnry kecnry marked this pull request as ready for review August 29, 2024 14:56
@kecnry kecnry added the trivial Only needs one approval instead of two label Aug 29, 2024
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks reasonable, so LGTM as long as this works for @camipacifici . Thanks!

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (8b3f3a1) to head (9646571).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
jdaviz/cli.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3176      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.01%     
==========================================
  Files         124      124              
  Lines       18347    18349       +2     
==========================================
  Hits        16221    16221              
- Misses       2126     2128       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry changed the title solara standalone: default to host='localhost' solara standalone: default to host='localhost' and allow mult instances Aug 29, 2024
@kecnry kecnry marked this pull request as draft August 29, 2024 16:14
@kecnry
Copy link
Member Author

kecnry commented Aug 29, 2024

The port=0 default requires a release and bump in pin to solara.... marking as draft until then.

@kecnry kecnry merged commit cd70c2e into spacetelescope:main Sep 6, 2024
17 checks passed
@kecnry kecnry deleted the solara-localhost branch September 6, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants