-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix typo on internal method #3172
Conversation
I swear I saw this fixed in another PR within the last couple of days, might be in review. |
Yeah, Kyle had also fixed this in #3157, which is waiting on another PR to get in first. |
If you don't want a trivial independent fix for this typo, feel free to close. Otherwise we can merge so we do not have to wait for that other PR that is currently "stuck". Up to you. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3172 +/- ##
=======================================
Coverage 88.42% 88.42%
=======================================
Files 122 122
Lines 18267 18267
=======================================
Hits 16153 16153
Misses 2114 2114 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't affect any functionality since both cases have the same typo, but doesn't hurt to get in sooner either.
Ok then, I merged it. One less typo to worry about. Hopefully the rebase will be easy for you. Thanks for your understanding! |
Description
Small typo but should still fix it.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.