Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface brightness -> solid angle conversion updates #3111

Merged
merged 12 commits into from
Aug 1, 2024
+137 −155

sb_unit -> sb_unit_selected for app._get_display_unit(sb) compatibility

96b9263
Select commit
Loading
Failed to load commit list.
Merged

Surface brightness -> solid angle conversion updates #3111

sb_unit -> sb_unit_selected for app._get_display_unit(sb) compatibility
96b9263
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 1, 2024 in 0s

88.89% (-0.04%) compared to a126296

View this Pull Request on Codecov

88.89% (-0.04%) compared to a126296

Details

Codecov Report

Attention: Patch coverage is 93.65079% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.89%. Comparing base (a126296) to head (96b9263).
Report is 8 commits behind head on main.

Files Patch % Lines
jdaviz/core/validunits.py 69.23% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3111      +/-   ##
==========================================
- Coverage   88.93%   88.89%   -0.04%     
==========================================
  Files         112      112              
  Lines       17411    17385      -26     
==========================================
- Hits        15485    15455      -30     
- Misses       1926     1930       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov