Improve overwrite warning behavior in export #3094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
added
bug
rosteen
requested review from
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3094 +/- ##
==========================================
- Coverage 88.73% 88.72% -0.01%
==========================================
Files 111 111
Lines 17262 17258 -4
==========================================
- Hits 15317 15313 -4
Misses 1945 1945 ☔ View full report in Codecov by Sentry. |
pllim
reviewed
Jul 17, 2024
cshanahan1
approved these changes
Jul 18, 2024
Co-authored-by: P. L. Lim <[email protected]>
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Jul 18, 2024
rosteen
added a commit
that referenced
this pull request
Jul 18, 2024
Co-authored-by: Ricky O'Steen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the overwrite warning when exporting plugin plots, and generally does some minor consistency improvements across the file types. This also fixes the bug where the overwrite confirmation overlay did not disappear after confirming that you want to overwrite.