Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gaia catalog to plugin #3090
Add Gaia catalog to plugin #3090
Changes from 7 commits
4d45bf5
75a9e20
766bc89
5ec1886
47d2b12
bf0bc7d
7d3d72f
415f642
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 177 in jdaviz/configs/imviz/plugins/catalogs/catalogs.py
Codecov / codecov/patch
jdaviz/configs/imviz/plugins/catalogs/catalogs.py#L176-L177
Check warning on line 180 in jdaviz/configs/imviz/plugins/catalogs/catalogs.py
Codecov / codecov/patch
jdaviz/configs/imviz/plugins/catalogs/catalogs.py#L179-L180
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this public in the user API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason making
self.app._catalog_source_table
public API belongs in a PR for enabling Gaia catalogs? I'm not really sure why we would do this so genuinely curious.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking more closely, I realize that this attr is on
app
and not the plugin, and the plugin has atable
attr – I agree with you, let's not do that. Apologies 🙊Check warning on line 183 in jdaviz/configs/imviz/plugins/catalogs/catalogs.py
Codecov / codecov/patch
jdaviz/configs/imviz/plugins/catalogs/catalogs.py#L182-L183
Check warning on line 186 in jdaviz/configs/imviz/plugins/catalogs/catalogs.py
Codecov / codecov/patch
jdaviz/configs/imviz/plugins/catalogs/catalogs.py#L185-L186
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but do we allow for passing any of those optional arguments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not, but maybe a particularly knowledgeable user could use the astroquery api to enable them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, since this is UI only, that is easy enough to increment on later if it causes any confusion.