-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show colormap previews in menu #2900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's one option to "center" by filling the full width
Co-authored-by: Kyle Conroy <[email protected]>
@kecnry I implemented your suggestions for centering/filling the width, works well. Thanks! I also talked to @Jenneh, she doesn't love the text-shadow (looks a little dated apparently) but thinks that being consistent with the layer tabs is more important than figuring out some other way of text outlining for now. Other than that I addressed her feedback by making the card |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2900 +/- ##
==========================================
- Coverage 88.70% 88.69% -0.01%
==========================================
Files 111 111
Lines 17125 17122 -3
==========================================
- Hits 15190 15187 -3
Misses 1935 1935 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Dev test failures are unrelated and I'll count @Jenneh as a second approval (we may revisit this and some related styling later but this is consistent with what exists). Merging. |
This shows a preview of each colormap in the menu where you select them. Opening as draft since I'm iterating a bit more with @Jenneh. Currently looks like this:
I'm having an infuriating time trying to get the card element to center within the selection item, if anyone has ideas feel free to chime in.