Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export spatial regions to ecsv #2874

Closed
wants to merge 6 commits into from

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented May 13, 2024

Reading these back in would be another ticket, but this adds parity with spectral regions so that we have a common file format that both can be written out to. This logic could eventually be moved upstream.

@rosteen rosteen added feature Feature request plugin Label for plugins common to multiple configurations labels May 13, 2024
@rosteen rosteen added this to the 3.11 milestone May 13, 2024
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But wait... shouldn't such serialization happen upstream in regions? We don't want to create a format that only we know. regions has its own I/O.

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.68%. Comparing base (37eba85) to head (c3ef255).
Report is 191 commits behind head on main.

Files Patch % Lines
jdaviz/configs/default/plugins/export/export.py 80.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2874      +/-   ##
==========================================
- Coverage   88.72%   88.68%   -0.04%     
==========================================
  Files         111      111              
  Lines       17102    17131      +29     
==========================================
+ Hits        15174    15193      +19     
- Misses       1928     1938      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosteen
Copy link
Collaborator Author

rosteen commented May 28, 2024

We decided offline that it would be better to implement this upstream from the start, closing.

@rosteen rosteen closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants