-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export spatial regions to ecsv #2874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But wait... shouldn't such serialization happen upstream in regions
? We don't want to create a format that only we know. regions
has its own I/O.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2874 +/- ##
==========================================
- Coverage 88.72% 88.68% -0.04%
==========================================
Files 111 111
Lines 17102 17131 +29
==========================================
+ Hits 15174 15193 +19
- Misses 1928 1938 +10 ☔ View full report in Codecov by Sentry. |
We decided offline that it would be better to implement this upstream from the start, closing. |
Reading these back in would be another ticket, but this adds parity with spectral regions so that we have a common file format that both can be written out to. This logic could eventually be moved upstream.