Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent composite array calls on subsets #2854

Merged
merged 1 commit into from
May 7, 2024

Conversation

bmorris3
Copy link
Contributor

@bmorris3 bmorris3 commented May 6, 2024

This PR prevents the DQ plugin from applying array compositing logic on spatial subsets that should be specific to image layers. I added a regression test that causes an AttributeError on main (thanks to @javerbukh for reporting!).

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label May 6, 2024
@bmorris3 bmorris3 added this to the 3.10.1 milestone May 6, 2024
@bmorris3 bmorris3 added the bug Something isn't working label May 6, 2024
@bmorris3 bmorris3 force-pushed the cubeviz-dq-bugfix branch from 6280f89 to bcea12f Compare May 6, 2024 20:42
@bmorris3 bmorris3 marked this pull request as ready for review May 6, 2024 20:44
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.93%. Comparing base (71c8197) to head (bcea12f).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2854      +/-   ##
==========================================
+ Coverage   88.90%   88.93%   +0.02%     
==========================================
  Files         111      111              
  Lines       17148    17165      +17     
==========================================
+ Hits        15246    15266      +20     
+ Misses       1902     1899       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javerbukh
Copy link
Contributor

javerbukh commented May 7, 2024

There's no longer a traceback but it does change the color of the background in the image viewer to the color of the subset
image

Edit: I see that is actually the DQ layer, which can be turned off. I think that's right so I'll go ahead and approve. Thank you!

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me and I'll trust @javerbukh that it fixes the bug - thanks for the quick fix!

@kecnry kecnry added the 💤backport-v3.10.x on-merge: backport to v3.10.x label May 7, 2024
@bmorris3 bmorris3 merged commit ded416e into spacetelescope:main May 7, 2024
22 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request May 7, 2024
pllim added a commit that referenced this pull request May 7, 2024
…4-on-v3.10.x

Backport PR #2854 on branch v3.10.x (Prevent composite array calls on subsets)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin Label for plugins common to multiple configurations 💤backport-v3.10.x on-merge: backport to v3.10.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants