-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent composite array calls on subsets #2854
Conversation
6280f89
to
bcea12f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2854 +/- ##
==========================================
+ Coverage 88.90% 88.93% +0.02%
==========================================
Files 111 111
Lines 17148 17165 +17
==========================================
+ Hits 15246 15266 +20
+ Misses 1902 1899 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff looks good to me and I'll trust @javerbukh that it fixes the bug - thanks for the quick fix!
…4-on-v3.10.x Backport PR #2854 on branch v3.10.x (Prevent composite array calls on subsets)
This PR prevents the DQ plugin from applying array compositing logic on spatial subsets that should be specific to image layers. I added a regression test that causes an AttributeError on main (thanks to @javerbukh for reporting!).
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.