Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option of using self derived interpolated profile for horne extract in specviz2d/spectral extraction plugin #2845

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Add option of using self derived interpolated profile for horne extract in specviz2d/spectral extraction plugin #2845

merged 5 commits into from
Jun 21, 2024

Conversation

cshanahan1
Copy link
Contributor

@cshanahan1 cshanahan1 commented May 3, 2024 •
edited
Loading

Add the option of using a 'self profile' for Horne extraction to the spectral extraction plugin in Specviz2D.

This PR also bumps up specreduce to the most recent 1.4.0 which contains the relevant changes there.

@github-actions github-actions bot added plugin Label for plugins common to multiple configurations specviz2d labels May 3, 2024
@cshanahan1 cshanahan1 added this to the 3.10.1 milestone May 6, 2024
@rosteen rosteen modified the milestones: 3.10.1, 3.10.2 May 14, 2024
bmorris3
bmorris3 reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some +1's on @kecnry's review comments.

pyproject.toml Outdated Show resolved Hide resolved
jdaviz/configs/specviz2d/plugins/spectral_extraction/tests/test_spectral_extraction.py Outdated Show resolved Hide resolved
@kecnry

This comment was marked as resolved.

Sign in to view
@cshanahan1 cshanahan1 force-pushed the spec_extract_self_profile branch from e5c898d to bb683bd Compare May 30, 2024 20:42
@cshanahan1 cshanahan1 modified the milestones: 3.10.2, 4.0 May 31, 2024
kecnry
kecnry reviewed May 31, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@cshanahan1 cshanahan1 force-pushed the spec_extract_self_profile branch from 6dc392a to 874662d Compare June 20, 2024 19:31
@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.80%. Comparing base (55e6f6a) to head (874662d).

❗ Current head 874662d differs from pull request most recent head 0e236e8

Please upload reports for the commit 0e236e8 to get more accurate results.

Files Patch % Lines
...plugins/spectral_extraction/spectral_extraction.py 95.23% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2845      +/-   ##
==========================================
+ Coverage   88.78%   88.80%   +0.01%     
==========================================
  Files         111      111              
  Lines       17197    17217      +20     
==========================================
+ Hits        15269    15289      +20     
  Misses       1928     1928

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmorris3
bmorris3 approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@bmorris3 bmorris3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tweaks. 🎉

kecnry
kecnry reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_interaction_in_ext_step also needs horne_ext_profile_selected, self_prof_n_bins, self_prof_interp_degree_x, self_interp_degree_y in its @observe so that changes to those will trigger an update to the live-preview.

jdaviz/configs/specviz2d/plugins/spectral_extraction/spectral_extraction.py Outdated Show resolved Hide resolved
jdaviz/configs/specviz2d/plugins/spectral_extraction/spectral_extraction.py Outdated Show resolved Hide resolved
jdaviz/configs/specviz2d/plugins/spectral_extraction/tests/test_spectral_extraction.py Outdated Show resolved Hide resolved
jdaviz/configs/specviz2d/plugins/spectral_extraction/tests/test_spectral_extraction.py Outdated Show resolved Hide resolved
@cshanahan1
Copy link
Contributor Author

@kecnry addressed all of your comments

@cshanahan1 cshanahan1 modified the milestones: 4.0, 3.11 Jun 21, 2024
kecnry
kecnry approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo, otherwise looks good to me! Thanks!

@cshanahan1 cshanahan1 merged commit 69fabb7 into spacetelescope:main Jun 21, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorris3 bmorris3 bmorris3 approved these changes

@kecnry kecnry kecnry approved these changes

@rosteen rosteen Awaiting requested review from rosteen rosteen is a code owner

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

@pllim pllim Awaiting requested review from pllim pllim is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay is a code owner

@gibsongreen gibsongreen Awaiting requested review from gibsongreen gibsongreen is a code owner

Assignees
No one assigned
Labels
plugin Label for plugins common to multiple configurations specviz2d
Projects
None yet
Milestone
3.11
Development

Successfully merging this pull request may close these issues.
4 participants
@cshanahan1 @kecnry @bmorris3 @rosteen