Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Line Analysis behavior before any lines are loaded #2831

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Fix Line Analysis behavior before any lines are loaded #2831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f67d5d1
Fix behavior before any lines are loaded
rosteen Apr 24, 2024
d3c4216
Update changelog
rosteen Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Other Changes and Additions

- Bump required Python version to 3.10. [#2757]

- Line menu in Redshift from Centroid section of Line Analysis now shows values in current units. [#2816]
- Line menu in Redshift from Centroid section of Line Analysis now shows values in current units. [#2816, #2831]

3.9.2 (unreleased)
==================
Expand Down
2 changes: 1 addition & 1 deletion jdaviz/configs/specviz/plugins/line_analysis/line_analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class LineAnalysis(PluginTemplateMixin, DatasetSelectMixin, SpectralSubsetSelect
results_computing = Bool(False).tag(sync=True)
results = List().tag(sync=True)
results_centroid = Float().tag(sync=True) # stored in AA units
line_menu_items = List([{}]).tag(sync=True)
line_menu_items = List([]).tag(sync=True)
sync_identify = Bool(True).tag(sync=True)
sync_identify_icon_enabled = Unicode(read_icon(os.path.join(ICON_DIR, 'line_select.svg'), 'svg+xml')).tag(sync=True) # noqa
sync_identify_icon_disabled = Unicode(read_icon(os.path.join(ICON_DIR, 'line_select_disabled.svg'), 'svg+xml')).tag(sync=True) # noqa
Expand Down
2 changes: 1 addition & 1 deletion jdaviz/configs/specviz/plugins/line_analysis/line_analysis.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
></v-progress-circular>
</div>

<div v-if="line_items.length > 0">
<div v-if="line_menu_items.length > 0">
<j-plugin-section-header>Redshift from Centroid</j-plugin-section-header>
<v-row>
<j-docs-link>Assign the centroid reported above to the observed wavelength of a given line and set the resulting redshift. Lines must be loaded and plotted through the Line Lists plugin first.</j-docs-link>
Expand Down