Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moment map when spectral units are in frequency #2803

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

javerbukh
Copy link
Contributor

Description

This pull request allows moment map to work with spectral axis units in frequency.

Fixes #2801

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Apr 16, 2024
@javerbukh javerbukh added this to the 3.10 milestone Apr 16, 2024
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, works in testing and looks good to me. I'm ok with making this a separate issue, but we also need to fix "Reference Wavelength" to say "Reference Frequency" if in those units (or pick a more generic term like "Reference Value").

Copy link
Contributor

@gibsongreen gibsongreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me!

@javerbukh javerbukh force-pushed the fix-moment-map-frequency-bug branch from cfe4ff9 to 85b8de4 Compare April 17, 2024 14:11
@javerbukh javerbukh enabled auto-merge (squash) April 17, 2024 14:43
@javerbukh javerbukh merged commit b0ec4c1 into spacetelescope:main Apr 17, 2024
13 of 14 checks passed
@javerbukh javerbukh deleted the fix-moment-map-frequency-bug branch April 17, 2024 14:46
rosteen pushed a commit to rosteen/jdaviz that referenced this pull request Apr 18, 2024
)

* Fix moment map when spectral units are in frequency

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Moment map creates nan image with frequency units and continuum
3 participants