Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify moment-map reference_wavelength hint text #2697

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Feb 12, 2024

Description

This pull request clarifies the test for the reference_wavelength input in moment-maps that the provided wavelength is the observed, not rest, value.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added UI/UX😍 💤backport-v3.8.x on-merge: backport to v3.8.x labels Feb 12, 2024
@kecnry kecnry added this to the 3.8.2 milestone Feb 12, 2024
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Feb 12, 2024
@kecnry kecnry added the trivial Only needs one approval instead of two label Feb 12, 2024
@kecnry kecnry marked this pull request as ready for review February 12, 2024 15:11
Copy link
Contributor

@PatrickOgle PatrickOgle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to mel

@kecnry kecnry merged commit 6bb67c4 into spacetelescope:main Feb 12, 2024
16 of 17 checks passed

This comment was marked as outdated.

@kecnry kecnry modified the milestones: 3.8.2, 3.9 Feb 12, 2024
@kecnry kecnry deleted the mm-text-clarification branch February 12, 2024 17:40
@kecnry kecnry mentioned this pull request Feb 12, 2024
gibsongreen pushed a commit to gibsongreen/jdaviz that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants