Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Only access meta when it exists #2683

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jan 30, 2024

Description

This pull request is to address an alleged crash that I cannot reproduce. But from the given traceback, I think this patch would have fixed it but maybe Kyle (the reporter) or Brett (the original code author) can confirm. Since this is to patch an unreleased feature (#2179), there is no need for change log.

Instead of crashing, I see the subset highlighted for the fake WCS layer, which I think is a completely different issue. This screenshot shows the subset overlay on the small fake WCS layer as a rectangle (it was drawn as a circle):

Screenshot 2024-01-30 181056

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added the no-changelog-entry-needed changelog bot directive label Jan 30, 2024
@pllim pllim added this to the 3.9 milestone Jan 30, 2024
@github-actions github-actions bot added imviz plugin Label for plugins common to multiple configurations labels Jan 30, 2024
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to remove the traceback and I can't think of any obvious unintended consequences. @bmorris3 - does this look reasonable to you?

Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👌🏻

Apologies I missed this earlier.

@pllim pllim merged commit 62231d8 into spacetelescope:main Feb 2, 2024
18 checks passed
@pllim pllim deleted the imviz-rot-subset-newview branch February 2, 2024 14:59
@pllim
Copy link
Contributor Author

pllim commented Feb 2, 2024

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants