-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: warning in javascript console #2668
fix: warning in javascript console #2668
Conversation
Uncaught SyntaxError: Unexpected token 'export'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple enough, I don't see the warning. Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2668 +/- ##
=======================================
Coverage 91.52% 91.53%
=======================================
Files 161 161
Lines 20196 20196
=======================================
+ Hits 18485 18486 +1
+ Misses 1711 1710 -1 ☔ View full report in Codecov by Sentry. |
Why would adding empty template section fix this? I am curious. Thanks! |
Uncaught SyntaxError: Unexpected token 'export'
Having an empty template on one line or no tempate tag at all would incorrectly fallback to the deprecated template format where template tags were ommited. See: spacetelescope/jdaviz#2668 and widgetti/solara#625
Having an empty template on one line or no tempate tag at all would incorrectly fallback to the deprecated template format where template tags were ommited. See: spacetelescope/jdaviz#2668 and widgetti/solara#625
Description
This pull request is to address the warning: "Uncaught SyntaxError: Unexpected token 'export'" in the javascript console
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.