Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warning in javascript console #2668

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

mariobuikhuizen
Copy link
Collaborator

Description

This pull request is to address the warning: "Uncaught SyntaxError: Unexpected token 'export'" in the javascript console

Screenshot 2024-01-23 at 15 53 49

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

Uncaught SyntaxError: Unexpected token 'export'
@github-actions github-actions bot added the embed Regarding issues with front-end embedding label Jan 23, 2024
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, I don't see the warning. Thanks!

@rosteen rosteen added this to the 3.9 milestone Jan 23, 2024
@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Jan 23, 2024
@kecnry kecnry enabled auto-merge (squash) January 23, 2024 15:13
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8edbdf0) 91.52% compared to head (b770503) 91.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2668   +/-   ##
=======================================
  Coverage   91.52%   91.53%           
=======================================
  Files         161      161           
  Lines       20196    20196           
=======================================
+ Hits        18485    18486    +1     
+ Misses       1711     1710    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim
Copy link
Contributor

pllim commented Jan 23, 2024

Why would adding empty template section fix this? I am curious. Thanks!

@kecnry kecnry merged commit 20b9de5 into spacetelescope:main Jan 23, 2024
16 of 17 checks passed
gibsongreen pushed a commit to gibsongreen/jdaviz that referenced this pull request Feb 12, 2024
Uncaught SyntaxError: Unexpected token 'export'
mariobuikhuizen added a commit to widgetti/ipyvue that referenced this pull request May 1, 2024
Having an empty template on one line or no tempate tag at all would
incorrectly fallback to the deprecated template format where template
tags were ommited.

See: spacetelescope/jdaviz#2668
and widgetti/solara#625
mariobuikhuizen added a commit to widgetti/ipyvue that referenced this pull request May 2, 2024
Having an empty template on one line or no tempate tag at all would
incorrectly fallback to the deprecated template format where template
tags were ommited.

See: spacetelescope/jdaviz#2668
and widgetti/solara#625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embed Regarding issues with front-end embedding no-changelog-entry-needed changelog bot directive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants