-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix removing cube data from cubeviz #2608
fix removing cube data from cubeviz #2608
Conversation
* fixes case where removing data from a cube viewer in cubeviz would raise a traceback from the plugins through the spectral viewer.
3dd102a
to
5ec8038
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2608 +/- ##
==========================================
+ Coverage 91.54% 91.55% +0.01%
==========================================
Files 161 161
Lines 19757 19842 +85
==========================================
+ Hits 18086 18166 +80
- Misses 1671 1676 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple enough, I confirmed that the fix works. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried with Gaussian Smooth and Moment Map. Didn't crash. Code looks like code.
Thanks!
…8-on-v3.8.x Backport PR #2608 on branch v3.8.x (fix removing cube data from cubeviz)
Description
This pull request fixes the case where removing data from a cube viewer in cubeviz would raise a traceback from the plugins through the spectral viewer. To reproduce: load cubeviz, open moment maps, calculate moment map (adding to viewer or not, does not matter), use the data-menu in the uncertainty viewer to remove the moment map. Previously this resulted in a callback from either line lists or line analysis.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.