ENH: Image rotation via WCS-only layers#2179

Merged

pllim merged 156 commits intospacetelescope:mainfrom bmorris3:wcs-only-layers

Jan 23, 2024

+2,803-842

Commits on Jan 17, 2024

Adding API for WCS-only layers for glue-based image rotation
bmorris3
committed
style fixes
bmorris3
committed
adapting improvements to work in other helpers
bmorris3
committed
more general change refdata method
bmorris3
committed
some test coverage for wcs-based rotation via glue
bmorris3
committed
Proposed changes for PR 2179 (ENH: Image rotation via WCS-only layers) (#4 )

pllim
and
bmorris3
committed
click data menu items to set as refdata
bmorris3
committed
using badge to note refdata in dropdown
bmorris3
committed
only add refdata tooltip for imviz, remove refdata references in tooltip
bmorris3
committed
tooltip improvements
bmorris3
committed
only show pointer cursor in imviz
bmorris3
committed
working towards default wcs base layer
bmorris3
committed
wcs linking requires wcs-only base layer
bmorris3
committed
click data menu items to set as refdata
bmorris3
committed
add data menu orientation options, handle linking changes
bmorris3
committed
fixing pixel scale calculation for gwcs w/ Roman
bmorris3
committed
refdata choice unavailable bugfix, better wcs fallbacks
bmorris3
committed
hide wcs-only layers from plugin dataset selectors
bmorris3
committed
making refdata selection specific to each viewer
bmorris3
committed
fix for subset support
bmorris3
committed
only match zoom level in viewers with common refdata
bmorris3
committed
reorganizing features in vue for links plugin
bmorris3
committed
adapting assumptions in tests for wcs-only layer implementation
bmorris3
committed
UI revisions
bmorris3
committed
ensuring wcs-only layers are centered near original dataset
bmorris3
committed
support batch loading wcs-only layers
bmorris3
committed
adding concept notebook
bmorris3
committed
bugfix when creating but not setting nu-el or nu-er orientations
bmorris3
committed
Update jdaviz/configs/imviz/plugins/links_control/links_control.vue

bmorris3
and
kecnry
committed
implementing review comments from Kyle
bmorris3
committed
debugging commit for Kyle
bmorris3
committed
specify rotation_angle traitlet as FloatHandleEmpty
bmorris3
committed
adding default to pixel scale ratio [ci skip]
bmorris3
committed
changelog update
bmorris3
committed
improve match between refdata sky area and wcs-only layer
bmorris3
committed
fixes for tests in image rotation
bmorris3
committed
Remove unused method and callback hook.

pllim
authored and
bmorris3
committed
DatasetSelect compatibility fix for wcs-only layers
bmorris3
committed
Remove imviz_rotation_by_hidden_layer.ipynb

pllim
authored and
bmorris3
committed
Update notebooks/concepts/imviz-wcs-rotation.ipynb

bmorris3
and
pllim
committed
Update notebooks/concepts/imviz-wcs-rotation.ipynb

bmorris3
and
pllim
committed
plugin warning when subsets exist on refdata change, error raised via api
bmorris3
committed
incorporate review comments from Kyle
bmorris3
committed
bugfixes: compass compat, change refdata to data layer on pixel linking
bmorris3
committed
Fix data deletion tests for image rotation
bmorris3
committed
better Imviz handling w/o WCS when WCS-linked
bmorris3
committed
better viewer zoom/center sync with different refdata
bmorris3
committed
Add warning when less than 2 data do not have WCS

javerbukh
authored and
bmorris3
committed
Move warning message and fix padding

javerbukh
authored and
bmorris3
committed
Update jdaviz/configs/imviz/plugins/links_control/links_control.py

authored and
bmorris3
committed
Apply suggestions from code review

javerbukh
and
bmorris3
committed
Address all review comments

javerbukh
authored and
bmorris3
committed
Only have warning when no data with wcs are present

javerbukh
authored and
bmorris3
committed
Use return instead of break

javerbukh
authored and
bmorris3
committed
Fix to work with one data with wcs

javerbukh
authored and
bmorris3
committed
move orientation layers out of expandable menu

kecnry
authored and
bmorris3
committed
fix legend margin by moving badge logic within data-menu

kecnry
authored and
bmorris3
committed
simplify data-menu logic

kecnry
authored and
bmorris3
committed
do not allow re-adding non-wcs data while wcs-linked

kecnry
authored and
bmorris3
committed
improve tooltip/alignment for trash icon in orientation layers

kecnry
authored and
bmorris3
committed
don't re-add layers that were intentionally removed

kecnry
authored and
bmorris3
committed
don't allow deleting "Default orientation" from data-menu

kecnry
authored and
bmorris3
committed
fix updating default viewer menu on change in link type

kecnry
authored and
bmorris3
committed
fix updating viewer_item for all viewers

kecnry
authored and
bmorris3
committed
fix codestyle error introduced in rebase

kecnry
authored and
bmorris3
committed
consolidate has_wcs logic

kecnry
authored and
bmorris3
committed
remove redundant lines setting refdata label

kecnry
authored and
bmorris3
committed
bugfixes for image rotation
bmorris3
committed
convert marker location from previous to new WCS when ref data changed

kecnry
authored and
bmorris3
committed
app._link_type set on init to pixels

kecnry
authored and
bmorris3
committed
marker to stick to location for wcs>pixel linking

kecnry
authored and
bmorris3
committed
marker visibility based on whether data is loaded in viewer

kecnry
authored and
bmorris3
committed
remove orientation layers from mouseover cycler

kecnry
authored and
bmorris3
committed
fix case original viewer reference WCS fails to convert to pixels

kecnry
authored and
bmorris3
committed
retain behavior only showing markers in viewer where they were created

kecnry
authored and
bmorris3
committed
drop markers on removing layer when reference data mapping fails

kecnry
authored and
bmorris3
committed
world_to_pixel compat with both fits and gwcs

kecnry
authored and
bmorris3
committed
(partial) support for markers added as pixel coords only

kecnry
authored and
bmorris3
committed
skip recomputing locations for configs without world/pixel info

kecnry
authored and
bmorris3
committed
warning in links_control when markers are present

kecnry
authored and
bmorris3
committed
move markers warnings above orientation layer section in plugin

kecnry
authored and
bmorris3
committed
fix traitlet name change in tests

kecnry
authored and
bmorris3
committed
code cleanup

kecnry
authored and
bmorris3
committed
orientation plugin UI/UX changes

kecnry
authored and
bmorris3
committed
consistent styling for alerts

kecnry
authored and
bmorris3
committed
update orientation icons and data-menu styling

kecnry
authored and
bmorris3
committed
improved v-alert styling in plugins

kecnry
authored and
bmorris3
committed
update internal references to "Links Control"

kecnry
authored and
bmorris3
committed
code cleanup

kecnry
authored and
bmorris3
committed
address any other possible places for wcs case-confusion

kecnry
authored and
bmorris3
committed
temporarily revert defaulting to aligned by WCS

kecnry
authored and
bmorris3
committed
codestyle

kecnry
authored and
bmorris3
committed
remove unused tests

kecnry
authored and
bmorris3
committed
or -> orientation in notebook

kecnry
authored and
bmorris3
committed
deprecate canvas rotation

kecnry
authored and
bmorris3
committed
consolidate deprecation handling of Links Control and Canvas Rotation

kecnry
authored and
bmorris3
committed
update references from Links Control -> Orientation

kecnry
authored and
bmorris3
committed
WIP: Fix astrowidgets API

pllim
authored and
bmorris3
committed
Fix rebase weirdness maybe

pllim
authored and
bmorris3
committed
We do not need the concept notebook anymore

pllim
authored and
bmorris3
committed
Revert removal of linked pan/zoom new code.

pllim
authored and
bmorris3
committed
Fix astrowidgets markers.

pllim
authored and
bmorris3
committed
clean up linked pan/zoom code

pllim
authored and
bmorris3
committed
Fix change log

pllim
authored and
bmorris3
committed
Privatize link_image_data because it is breaky

pllim
authored and
bmorris3
committed
Fix linked pan/zoom again

pllim
authored and
bmorris3
committed
Let's hope for the best

pllim
and
bmorris3
committed
Ensure subsets are not visible on WCS-only layers
bmorris3
committed
Update jdaviz/configs/imviz/plugins/orientation/orientation.py

bmorris3
and
pllim
committed
Update jdaviz/core/template_mixin.py

bmorris3
and
pllim
committed
applying changes

cshanahan1
authored and
bmorris3
committed
fixed one failing test

cshanahan1
authored and
bmorris3
committed
fixed other failing subset test

cshanahan1
authored and
bmorris3
committed
fix aper phot test

cshanahan1
authored and
bmorris3
committed
code style

cshanahan1
authored and
bmorris3
committed
review changes

cshanahan1
authored and
bmorris3
committed
fix test

cshanahan1
authored and
bmorris3
committed
.;

cshanahan1
authored and
bmorris3
committed
modified subset centroid test

cshanahan1
authored and
bmorris3
committed
Update test_subset_centroid.py
bmorris3
committed
fix failures after rebase
bmorris3
committed
rename links control to orientation in docs
bmorris3
committed
Merge pull request spacetelescope#2589 from pllim/fix-ann-reg-test

pllim
authored and
bmorris3
committed
Clare changes review as more changes

pllim
authored and
bmorris3
committed
get_interactive_regions returns sky region

pllim
authored and
bmorris3
committed
Fix changelog caused by rebase

pllim
authored and
bmorris3
committed
Remove unnecessary link_type.lower() calls

pllim
authored and
bmorris3
committed
f-string not recommended for logger

pllim
authored and
bmorris3
committed
Update docs/imviz/plugins.rst
bmorris3
committed
image rotation fixes for multiple viewers
bmorris3
committed
Update jdaviz/app.py

bmorris3
and
pllim
committed
Update jdaviz/app.py

bmorris3
and
pllim
committed
Update jdaviz/app.py
bmorris3
committed
fix case without refdata
bmorris3
committed
fixes (lots and lots)
bmorris3
committed
handling case for viewers without data
bmorris3
committed
Update jdaviz/core/tools.py

bmorris3
and
pllim
committed
fix matched pan zoom
bmorris3
committed
Update jdaviz/configs/imviz/plugins/orientation/orientation.py
bmorris3
committed
Update jdaviz/configs/imviz/plugins/orientation/orientation.py
bmorris3
committed
Update jdaviz/configs/imviz/plugins/orientation/orientation.py
bmorris3
committed
fixes from github suggestions
bmorris3
committed
review comments from Kyle
bmorris3
committed
fix centering on click test
bmorris3
committed
reducing redundancy
bmorris3
committed
add warning to astrowidgets_api zoom_level
bmorris3
committed
data menu whac-a-mole fixes
bmorris3
committed
Update jdaviz/core/astrowidgets_api.py

bmorris3
and
pllim
committed
fix rebase error
bmorris3
committed
DOC: Fix warning indentation
pllim
authored