Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid JSON serialization warning #2011

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Feb 13, 2023

Description

Avoid JSON serialization warning when loading valid data but axis not ready yet.

I started seeing JSON serialization warnings even when I load handmade data that I know to be valid. I tracked it down to x_min and x_max being set to -inf and inf (see diff). The warnings are harmless but also annoying and unnecessary.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

when loading valid data but axis not ready yet.
@pllim pllim added the 💤 backport-v3.3.x on-merge: backport to v3.3.x label Feb 13, 2023
@pllim pllim added this to the 3.3.1 milestone Feb 13, 2023
Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me!

@pllim pllim merged commit 4219b94 into spacetelescope:main Feb 16, 2023
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Feb 16, 2023
@pllim pllim deleted the shhhh-json-serialization branch February 16, 2023 16:39
pllim added a commit that referenced this pull request Feb 16, 2023
…1-on-v3.3.x

Backport PR #2011 on branch v3.3.x (Avoid JSON serialization warning)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💤 backport-v3.3.x on-merge: backport to v3.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants