-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Mosviz Zoom Bug Typo #1992
Fix Mosviz Zoom Bug Typo #1992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬
Co-authored-by: P. L. Lim <[email protected]>
Co-authored-by: P. L. Lim <[email protected]>
Co-authored-by: P. L. Lim <[email protected]>
Codecov ReportBase: 91.96% // Head: 91.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1992 +/- ##
=======================================
Coverage 91.96% 91.97%
=======================================
Files 140 140
Lines 15315 15322 +7
=======================================
+ Hits 14085 14092 +7
Misses 1230 1230
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This comment was marked as resolved.
This comment was marked as resolved.
I don't think this needs backporting at all. I don't see this error in 3.2.x code. Maybe we don't need a new release for Webbminar after all? jdaviz/jdaviz/configs/mosviz/helper.py Lines 316 to 317 in a93fef4
|
Ah, this bug was introduced in #1958 that was never backported. |
Description
Oops...
Pretty alarming we didn't have a test for this. I added a quick and dirty one just to get this in ASAP.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.