-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Home after markers no longer crash Imviz #1971
Conversation
Codecov ReportBase: 91.93% // Head: 91.94% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1971 +/- ##
=======================================
Coverage 91.93% 91.94%
=======================================
Files 140 140
Lines 15310 15311 +1
=======================================
+ Hits 14076 14078 +2
+ Misses 1234 1233 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -323,6 +323,10 @@ def test_mvp_markers(self): | |||
# TODO: How to check imviz.app.data_collection.links is correct? | |||
assert len(self.imviz.app.data_collection.links) == 14 | |||
|
|||
# Just want to make sure nothing crashes. Zooming already testing elsewhere. | |||
# https://github.com/spacetelescope/jdaviz/pull/1971 | |||
self.viewer.zoom_level = 'fit' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, I did confirm locally that this test fails on main
without this patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elegant fix, thanks!
(Failure seems unrelated, but I started the failed job to try to get CI green)
The dev failure is unrelated. I thought numpy-dev fixed that Thanks for the reviews! |
…1-on-v3.2.x Backport PR #1971 on branch v3.2.x (BUG: Home after markers no longer crash Imviz)
Description
This pull request is to prevent crashing in Imviz when Home is clicked on after markers are added.
Fixes #1964
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.