Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename residuals_expose to residuals_calculate #1891

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Dec 5, 2022

Description

This pull request is a follow-up to #1864 and renames "expose residuals" to "calculate residuals" (and the underyling traitlet from residuals_expose to residuals_calculate after feedback.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry force-pushed the residuals_calculate branch from 366bfd0 to e54e8b0 Compare December 5, 2022 17:19
@kecnry kecnry added this to the 3.2 milestone Dec 5, 2022
@kecnry kecnry marked this pull request as ready for review December 5, 2022 17:46
@pllim
Copy link
Contributor

pllim commented Dec 5, 2022

Which PO should we ping to bless the name?

@pllim pllim merged commit 7973e71 into spacetelescope:main Dec 9, 2022
@kecnry kecnry deleted the residuals_calculate branch December 9, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants