-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore console log for Windows #1887
Conversation
Codecov ReportBase: 88.45% // Head: 88.45% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1887 +/- ##
=======================================
Coverage 88.45% 88.45%
=======================================
Files 95 95
Lines 10533 10533
=======================================
Hits 9317 9317
Misses 1216 1216 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! One of the two users (me) didn't even notice. 😆
Maybe second approval should come from a Mac user...
Co-authored-by: P. L. Lim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to change anything on the mac side, glad to see this back on windows!
Thanks for the eyes! |
This comment was marked as resolved.
This comment was marked as resolved.
Ugh... backport failed... @pllim as the second other windows jdaviz user, is this bugfix worth the backport? |
Since it is there for a loooong time and no one complained, probably don't have to backport. 😆 |
Move changelog entry for failed backport #1887
Description
HOOOLLEY CRAP I finally fixed it!!
At some point in the past (probably a year), I completely lost console logging whenever I launched jdaviz in "desktop" mode. I was going to report it as a bug, but no one else was complaining about it, so I figured it was just me. And I've been flying blind ever since!
But then I found a little gem in the python docs:
specifically:
Turns out it probably wasn't just me; this probably affected all native windows users, all 2 of us!
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.