Moving color cycler to JdavizViewerMixin

[bmorris3]

Description

In #1674 I introduced a color cycler so that each new data added to an instance of the Application would have a distinct color (up to N colors). While testing #1864, @kecnry pointed out that (1) the cycler was accidentally broken by #1742, and (2) the color cycler should cycle on the viewer level rather than the app level. I implement that here.

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[kecnry]

Thanks for the quick fix (and sorry for breaking it in the first place)!

[kecnry]

I think test failures are unrelated? But probably something we will want to have fixed for release - @pllim?

[rosteen]

I think test failures are unrelated? But probably something we will want to have fixed for release - @pllim?

I just restarted test jobs on main to see if it happens there as well.

[rosteen]

The test seems to be passing on main...

[bmorris3]

I can't track down why this error occurs, but this note from a comment in the traceback is a bit haunting.

[kecnry]

I think they somewhat randomly fail on the cube play button. @bmorris3 - might be worth just restarting tests and if they eventually pass we can open a follow-up issue to write more robust tests?

[codecov]

Codecov Report

Base: 88.37% // Head: 88.37% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d769ca2) compared to base (0b9d469).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1866   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files          95       95           
  Lines       10455    10456    +1     
=======================================
+ Hits         9240     9241    +1     
  Misses       1215     1215           

Impacted Files	Coverage Δ
jdaviz/app.py	94.15% <100.00%> (-0.01%)	⬇️
jdaviz/configs/default/plugins/viewers.py	96.77% <100.00%> (+0.05%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[bmorris3]

The failure is indeed intermittent. I can't reproduce it locally, and rerunning the Actions succeeded. 🤷🏻‍♂️

Thanks for your help!

[pllim]

Tsk tsk... Why would goto_first not go to first slice? Did you say you see this a lot across all the PRs? Is it always the OSX or doesn't matter? If you see it again, please open issue. I thought you saw it while the play button was active but by the time goto_first happens, it should have stopped... unless join doesn't wait for the thread to terminate first before Python runs the next command? 🤯

jdaviz/jdaviz/configs/cubeviz/plugins/slice/slice.py

Line 220 in bcc29e7

self._player.join(timeout=0)

        # NOTE: Hard to check sl.slice here because it is non-deterministic.
    
        sl.vue_goto_first()
>       assert sl.slice == 0
E       AssertionError: assert 1 == 0