Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: added missing comma in choices for trace peak method #1844

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Nov 15, 2022

Description

This pull request fixes a small typo that combined the "Centroid" and "Max" options in the dropdown for peak method in the spectral extraction plugin.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added the trivial Only needs one approval instead of two label Nov 15, 2022
@kecnry kecnry added this to the 3.1.1 milestone Nov 15, 2022
@kecnry kecnry marked this pull request as ready for review November 15, 2022 19:36
@pllim
Copy link
Contributor

pllim commented Nov 15, 2022

Hmm how did the CI not catch this?

@pllim pllim added bug Something isn't working 💤backport-v3.1.x on-merge: backport to v3.1.x labels Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 88.29% // Head: 88.29% // No change to project coverage 👍

Coverage data is based on head (74c70d8) compared to base (9a1d414).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1844   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files          95       95           
  Lines       10396    10396           
=======================================
  Hits         9179     9179           
  Misses       1217     1217           
Impacted Files Coverage Δ
...plugins/spectral_extraction/spectral_extraction.py 91.40% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneaky bug!

@pllim pllim merged commit b5bbccd into spacetelescope:main Nov 16, 2022
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Nov 16, 2022
@kecnry kecnry deleted the comma-coma branch November 16, 2022 02:24
pllim added a commit that referenced this pull request Nov 16, 2022
…4-on-v3.1.x

Backport PR #1844 on branch v3.1.x (FIX: added missing comma in choices for trace peak method)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working specviz2d trivial Only needs one approval instead of two 💤backport-v3.1.x on-merge: backport to v3.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants