-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: added missing comma in choices for trace peak method #1844
Conversation
Hmm how did the CI not catch this? |
Codecov ReportBase: 88.29% // Head: 88.29% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1844 +/- ##
=======================================
Coverage 88.29% 88.29%
=======================================
Files 95 95
Lines 10396 10396
=======================================
Hits 9179 9179
Misses 1217 1217
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sneaky bug!
…for trace peak method
…4-on-v3.1.x Backport PR #1844 on branch v3.1.x (FIX: added missing comma in choices for trace peak method)
Description
This pull request fixes a small typo that combined the "Centroid" and "Max" options in the dropdown for peak method in the spectral extraction plugin.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.