-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Deprecate CubeViz, MosViz, and SpecViz #1809
Conversation
that are CubeViz, MosViz, and SpecViz.
Codecov ReportBase: 88.04% // Head: 88.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1809 +/- ##
=======================================
Coverage 88.04% 88.05%
=======================================
Files 95 95
Lines 10197 10203 +6
=======================================
+ Hits 8978 8984 +6
Misses 1219 1219
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's past time for this, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @camipacifici also said she was going to check... 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋🏻 Later, "V"s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two notebooks in jdat_notebooks need updating:
- ifu_optimal
- specviz_notebook_gui_interaction_redshift
I will take care of these.
Approved!
Thanks, all! |
Description
This pull request is to formally deprecate old helper classes with capital V. That includes CubeViz, MosViz, and SpecViz.
This emits deprecation warning and removes them from high-level imports like
from jdaviz import CubeViz
but the classes are still there for a few more releases.I think @orifox and @ojustino are both active in JDAT notebooks, so they can confirm whether we can go ahead with this or not.
Fixes #857
After merge
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.