Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mosviz visibility fallback more robust #1808

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Make mosviz visibility fallback more robust #1808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ Imviz
Mosviz
^^^^^^

- Data unassigned a row is hidden under the subdropdown in the data dropdown. [#1798]
- Data unassigned a row is hidden under the subdropdown in the data dropdown. [#1798, #1808]

Specviz
^^^^^^^
Expand Down
3 changes: 1 addition & 2 deletions jdaviz/components/viewer_data_select.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,9 @@ module.exports = {
return false
} else if (this.$props.viewer.reference === 'image-viewer' && item.type !== 'image') {
return false
} else if ((item.meta.mosviz_row !== undefined) && (item.meta.mosviz_row !== null)) {
} else {
return this.dataItemInViewer(item, returnExtraItems)
}
return !returnExtraItems
} else if (this.$props.viewer.config === 'cubeviz') {
if (this.$props.viewer.reference === 'spectrum-viewer') {
if (item.meta.Plugin === undefined) {
Expand Down