Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rainbow and reverse rainbow colormaps #1785

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Oct 26, 2022

Description

This pull request is to add requested colormaps to image viewer.

Screenshot 2022-10-26 144929

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added the feature Feature request label Oct 26, 2022
@pllim pllim added this to the 3.1 milestone Oct 26, 2022
@github-actions github-actions bot added the imviz label Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 87.82% // Head: 87.81% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (7d4c5a4) compared to base (1acc87d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1785      +/-   ##
==========================================
- Coverage   87.82%   87.81%   -0.01%     
==========================================
  Files          95       95              
  Lines       10167    10167              
==========================================
- Hits         8929     8928       -1     
- Misses       1238     1239       +1     
Impacted Files Coverage Δ
jdaviz/app.py 93.78% <100.00%> (ø)
jdaviz/utils.py 89.38% <0.00%> (-0.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know why you'd want to, but it does work! 😂

@camipacifici
Copy link
Contributor

Great for velocity fields :)
Looks good to me, thank you!

@rosteen rosteen modified the milestones: 3.1, 3.2 Oct 26, 2022
@kecnry
Copy link
Member

kecnry commented Oct 26, 2022

I was (mostly) joking - a lot of these colormaps have been... misused... when trying to actually convey information in figures, etc, but they're definitely still useful for visualization/inspection purposes so the more the merrier!

I think this qualifies as trivial, so feel free to merge once the restrictions on main are lifted and conflicts/milestone resolved.

colormaps for image viewer.
@pllim pllim force-pushed the taste-the-rainbow branch from 729bae9 to 7d4c5a4 Compare October 26, 2022 21:04
@pllim
Copy link
Contributor Author

pllim commented Oct 26, 2022

Does Cami's comment count as second approval? 😆

@pllim pllim merged commit f20d853 into spacetelescope:main Oct 27, 2022
@pllim pllim deleted the taste-the-rainbow branch October 27, 2022 17:46
@pllim
Copy link
Contributor Author

pllim commented Oct 27, 2022

Thanks for the quick reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants