fix nested toolbar in specviz2d/mosviz 2d profile viewer #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecnry
force-pushed
the
fix-spec2d-toolbar
branch
from
1fb9160 to
554375a
Compare
kecnry
requested review from
duytnguyendtn,
rosteen,
javerbukh,
ojustino,
pllim and
bmorris3
as code owners
Codecov ReportBase: 87.81% // Head: 87.81% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1778 +/- ##
=======================================
Coverage 87.81% 87.81%
=======================================
Files 95 95
Lines 10165 10165
=======================================
Hits 8926 8926
Misses 1239 1239
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kecnry
commented
Oct 25, 2022
Comment on lines
-800
to
801
| raise KeyError(f"The SRCTYPE keyword in the header of file {fname}" | ||
| raise KeyError(f"The SRCTYPE keyword in the header of file {fname} " | ||
| "is not populated (expected values: EXTENDED or POINT)") from e |
There was a problem hiding this comment.
not really applicable to the fix here, but ran into it while testing mosviz and I don't think it warrants its own PR...
pllim
approved these changes
Oct 25, 2022
| @@ -99,7 +99,7 @@ def set_plot_axes(self): | |||
|
|
|||
|
|
|||
| @viewer_registry("mosviz-profile-2d-viewer", label="Spectrum 2D (Mosviz)") | |||
| class MosvizProfile2DView(BqplotImageView, JdavizViewerMixin): | |||
| class MosvizProfile2DView(JdavizViewerMixin, BqplotImageView): | |||
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Oct 25, 2022
…iz 2d profile viewer
pllim
added a commit
that referenced
this pull request
Oct 25, 2022
…8-on-v3.0.x Backport PR #1778 on branch v3.0.x (fix nested toolbar in specviz2d/mosviz 2d profile viewer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the nested toolbar in the 2d spectrum viewers in specviz2d and mosviz (see #1679 - which was supposed to replace the original toolbar with the nested toolbar, but forgot to change the inheritance order of this viewer).
Before:
After:
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.