-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix astropy version check for filter_non_finite in modeling within aper phot plugin #1769
Conversation
1fb038f
to
cedb088
Compare
for filter_non_finite in modeling within aper phot plugin.
cedb088
to
a673139
Compare
Codecov ReportBase: 87.77% // Head: 87.77% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1769 +/- ##
=======================================
Coverage 87.77% 87.77%
=======================================
Files 95 95
Lines 10162 10162
=======================================
Hits 8920 8920
Misses 1242 1242
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple enough, thanks!
It's my bad on the initial check. I guess I didn't take account that 5.1 would have bug fix release... 😬 |
…ilter_non_finite in modeling within aper phot plugin
…9-on-v3.0.x Backport PR #1769 on branch v3.0.x (BUG: Fix astropy version check for filter_non_finite in modeling within aper phot plugin)
Description
Hopefully this will make CI green again. astropy v5.1.1 was released this morning.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.