Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix astropy version check for filter_non_finite in modeling within aper phot plugin #1769

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Oct 24, 2022

Description

Hopefully this will make CI green again. astropy v5.1.1 was released this morning.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added bug Something isn't working trivial Only needs one approval instead of two 💤 backport-v3.0.x on-merge: backport to v3.0.x labels Oct 24, 2022
@pllim pllim added this to the 3.0.3 milestone Oct 24, 2022
@github-actions github-actions bot added the imviz label Oct 24, 2022
@pllim pllim force-pushed the fix-aperphot-astropy-5.1.1 branch from 1fb038f to cedb088 Compare October 24, 2022 16:14
for filter_non_finite in modeling within aper phot plugin.
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 87.77% // Head: 87.77% // No change to project coverage 👍

Coverage data is based on head (a673139) compared to base (c76e9fb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1769   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files          95       95           
  Lines       10162    10162           
=======================================
  Hits         8920     8920           
  Misses       1242     1242           
Impacted Files Coverage Δ
...imviz/plugins/aper_phot_simple/aper_phot_simple.py 92.05% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, thanks!

@pllim pllim marked this pull request as ready for review October 24, 2022 16:33
@pllim
Copy link
Contributor Author

pllim commented Oct 24, 2022

It's my bad on the initial check. I guess I didn't take account that 5.1 would have bug fix release... 😬

@pllim pllim merged commit a7837c4 into spacetelescope:main Oct 24, 2022
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Oct 24, 2022
…ilter_non_finite in modeling within aper phot plugin
@pllim pllim deleted the fix-aperphot-astropy-5.1.1 branch October 24, 2022 16:35
rosteen added a commit that referenced this pull request Oct 24, 2022
…9-on-v3.0.x

Backport PR #1769 on branch v3.0.x (BUG: Fix astropy version check for filter_non_finite in modeling within aper phot plugin)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working imviz trivial Only needs one approval instead of two 💤 backport-v3.0.x on-merge: backport to v3.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants